tandem/camper
tandem
/
camper
2
0
Fork 0
Code Issues 7 Pull Requests Packages Projects Releases Wiki Activity
camper/test/setup_redsys.sql

79 lines
3.4 KiB
MySQL
Raw Normal View History

Implement Redsys request signature in PostgreSQL Every company need to have its own merchant code and encryption key, thus it is not possible to use environment variables to keep that data, and i have to store it in the database. I do not want to give SELECT permission on the encryption key to guest, because i am going to fuck it up sooner or later, and everyone would be able to read that secret; i know it would. Therefore, i need a security definer function that takes the data to encrypt, use the key to encrypt it, and returns the result; nobody else should have access to that key, not even admins! By the way, i found out that every merchant receives the same key, thus it is not a problem to keep it in the repository. Since i need that SQL function to encrypt the data, i thought that i may go the whole nine yards and sign the request in PostgreSQL too, after all the data to sign comes from there, and it has JSON functions to create and base64-code an object. Fortunately, pg_crypto has all the functions that i need, but i can no longer keep that extension inside the auth schema, because it is used from others, and the public schema, like every other extensions, seems more appropriate. Instead of having the list of currency and language codes that Redsys uses as constants in the code, i moved that as field to the currency and language relations, so i can simply pass the lang_tag to the function and it can transform that tag to the correct code; the currency is from the company’s relation, since it is the only currency used in the whole application (for now). As a consequence, i had to grant execute to currency and the parse_price functions to guest, too. To generate the test data used in the unit tests, i used a third-party PHP implementation[0], but i only got from that the resulting base64-coded JSON object and signature, using the same that as in the unit test, and did not use any code from there. PostgreSQL formats the JSON as text differently than most implementations i have seen: it adds spaces between the key name and the colons, and space between the value and the separating comma. The first implementation used replace() to format the JSON as exactly as the PHP implementation, so that the result matches, and then tried to do generate the form by hand using the output from PostgreSQL without the replace(), to verify that Redsys would still accept my input. Finally, i adjusted the unit test to whatever pg_prove said it was getting from the function. I still have the form’s action hard-codded to the test environment, but the idea is that administrators should be able to switch from test to live themselves. That means that i need that info in the redsys relation as well. I think this is one of the few use cases for SQL’s types, because it is unlikely to change anytime soon, and i do not need the actual labels. Unfortunately, i could not use enumerations for the request’s transaction type because i can not attach an arbitrary number to the enum’s values. Having a relation is overkill, because i would need a constant in Go to refer to its primary key anyway, thus i kept the same constant i had before for that. Language and currency constant went out, as this is in the corresponding relations. In setup_redsys i must have a separate update if the encrypt_key is null because PostgreSQL checks constraints before key conflict, and i do not want to give a default value to the key if the row is not there yet. The problem is that i want to use null to mean “keep the same password”, because it is what i intend to do with the user-facing form: leave the input empty to keep the same password. As now Go needs to pass composite types back and forth with PostgreSQL, i need to register these types, and i have to do it every time because the only moment i have access to the non-pooled connection is in the AfterConnect function, but at that point i have no idea whether the user is going to request a payment. I do not know how much the performance degrades because of this. [0]: https://github.com/ssheduardo/sermepa/blob/master/src/Sermepa/Tpv/Tpv.php
2023-10-26 23:52:04 +00:00
-- Test setup_redsys
set client_min_messages to warning;
create extension if not exists pgtap;
reset client_min_messages;
begin;
select plan(15);
set search_path to camper, public;
select has_function('camper', 'setup_redsys', array['integer', 'text', 'integer', 'redsys_environment', 'redsys_integration', 'text']);
select function_lang_is('camper', 'setup_redsys', array['integer', 'text', 'integer', 'redsys_environment', 'redsys_integration', 'text'], 'plpgsql');
select function_returns('camper', 'setup_redsys', array['integer', 'text', 'integer', 'redsys_environment', 'redsys_integration', 'text'], 'void');
select isnt_definer('camper', 'setup_redsys', array['integer', 'text', 'integer', 'redsys_environment', 'redsys_integration', 'text']);
select volatility_is('camper', 'setup_redsys', array['integer', 'text', 'integer', 'redsys_environment', 'redsys_integration', 'text'], 'volatile');
select function_privs_are('camper', 'setup_redsys', array ['integer', 'text', 'integer', 'redsys_environment', 'redsys_integration', 'text'], 'guest', array[]::text[]);
select function_privs_are('camper', 'setup_redsys', array ['integer', 'text', 'integer', 'redsys_environment', 'redsys_integration', 'text'], 'employee', array[]::text[]);
select function_privs_are('camper', 'setup_redsys', array ['integer', 'text', 'integer', 'redsys_environment', 'redsys_integration', 'text'], 'admin', array['EXECUTE']);
select function_privs_are('camper', 'setup_redsys', array ['integer', 'text', 'integer', 'redsys_environment', 'redsys_integration', 'text'], 'authenticator', array[]::text[]);
set client_min_messages to warning;
truncate redsys cascade;
truncate company cascade;
insert into company (company_id, business_name, vatin, trade_name, phone, email, web, address, city, province, postal_code, rtc_number, country_code, currency_code, default_lang_tag)
values (1, 'Company 2', 'XX123', '', '555-555-555', 'a@a', '', '', '', '', '', '', 'ES', 'EUR', 'ca')
, (2, 'Company 4', 'XX234', '', '666-666-666', 'b@b', '', '', '', '', '', '', 'FR', 'USD', 'ca')
;
prepare redsys_data as
select company_id, merchant_code, terminal_number, environment::text, integration::text, encrypt_key
from redsys
;
select lives_ok(
$$ select setup_redsys(1, '111111111', 1, 'live', 'insite', encode(E'\\x1111', 'base64')) $$,
'Should be able to setup Redsys parameters for the first company'
);
select lives_ok(
$$ select setup_redsys(2, '222222222', 2, 'test', 'redirect', encode(E'\\x1212', 'base64')) $$,
'Should be able to setup Redsys parameters for the second company'
);
select bag_eq(
'redsys_data',
$$ values (1, '111111111', 1, 'live', 'insite', E'\\x1111'::bytea),
(2, '222222222', 2, 'test', 'redirect', E'\\x1212'::bytea)
$$,
'Should have inserted all Redsys parameters'
);
select lives_ok(
$$ select setup_redsys(1, '999999999', 9, 'live', 'redirect', encode(E'\\x9119', 'base64')) $$,
'Should be able to update Redsys parameters for the first company'
);
select lives_ok(
$$ select setup_redsys(2, '123456789', 5, 'live', 'redirect', NULL) $$,
'Should be able to update Redsys parameters for the second company, leaving the encrypt key alone'
);
select bag_eq(
'redsys_data',
$$ values (1, '999999999', 9, 'live', 'redirect', E'\\x9119'::bytea),
(2, '123456789', 5, 'live', 'redirect', E'\\x1212'::bytea)
$$,
'Should have updated all Redsys parameters'
);
reset client_min_messages;
select *
from finish();
rollback;