From 93364b896ce983855f8009f45df7ecafcb72a6fc Mon Sep 17 00:00:00 2001
From: jordi fita mas <jordi@tandem.blog>
Date: Tue, 15 Aug 2023 20:52:14 +0200
Subject: [PATCH] =?UTF-8?q?Remove=20the=20menu=20aria=20role=20from=20admi?=
 =?UTF-8?q?n=E2=80=99s=20layout?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Elements with the menu role require complex functionality and a keyboard
navigation[0] that i do not implement, thus the role is incorrect and
more harmful than anything else.

[0]: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role
---
 web/templates/admin/layout.gohtml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/web/templates/admin/layout.gohtml b/web/templates/admin/layout.gohtml
index f59154c..ae46f6e 100644
--- a/web/templates/admin/layout.gohtml
+++ b/web/templates/admin/layout.gohtml
@@ -24,12 +24,12 @@
                     <img src="/me/avatar" alt="{{( gettext "Avatar" )}}" width="70" height="70">
                     <span>{{( pgettext "User Menu" "title" )}}</span>
                 </summary>
-                <ul role="menu">
-                    <li role="presentation" class="icon_profile">
-                        <a role="menuitem" href="/me">{{( pgettext "Profile" "title" )}}</a>
+                <ul>
+                    <li class="icon_profile">
+                        <a href="/me">{{( pgettext "Profile" "title" )}}</a>
                     </li>
-                    <li role="presentation" class="icon_logout">
-                        <button role="menuitem" data-hx-delete="/me/session" data-hx-headers='{ {{ CSRFHeader }} }'
+                    <li class="icon_logout">
+                        <button data-hx-delete="/me/session" data-hx-headers='{ {{ CSRFHeader }} }'
                         >{{( pgettext "Logout" "action" )}}</button>
                     </li>
                 </ul>
@@ -39,9 +39,9 @@
 </header>
 {{ if isLoggedIn -}}
     <nav>
-        <ul role="menu">
-            <li role="presentation">
-                <a role="menuitem" href="/admin/">{{( pgettext "Dashboard" "title" )}}</a>
+        <ul>
+            <li>
+                <a href="/admin/">{{( pgettext "Dashboard" "title" )}}</a>
             </li>
         </ul>
     </nav>