From ab0cfb4100518c0986d0af097b9421fa45b2b773 Mon Sep 17 00:00:00 2001 From: jordi fita mas Date: Mon, 31 Jul 2023 14:18:17 +0200 Subject: [PATCH] Add the campsite_type relation Part of #25. --- deploy/campsite_type.sql | 40 +++++++++++ revert/campsite_type.sql | 7 ++ sqitch.plan | 1 + test/campsite_type.sql | 151 +++++++++++++++++++++++++++++++++++++++ verify/campsite_type.sql | 19 +++++ 5 files changed, 218 insertions(+) create mode 100644 deploy/campsite_type.sql create mode 100644 revert/campsite_type.sql create mode 100644 test/campsite_type.sql create mode 100644 verify/campsite_type.sql diff --git a/deploy/campsite_type.sql b/deploy/campsite_type.sql new file mode 100644 index 0000000..58316fd --- /dev/null +++ b/deploy/campsite_type.sql @@ -0,0 +1,40 @@ +-- Deploy camper:campsite_type to pg +-- requires: roles +-- requires: schema_camper +-- requires: company + +begin; + +set search_path to camper, public; + +create table campsite_type ( + campsite_type_id serial primary key, + company_id integer not null references company, + slug uuid not null unique default gen_random_uuid(), + name text not null constraint name_not_empty check(length(trim(name)) > 0), + description xml not null default ''::xml, + rules xml not null default '', + booking_terms xml not null default '', + active boolean not null default true +); + +grant select on table campsite_type to employee; +grant select, insert, update, delete on table campsite_type to admin; + +grant usage on sequence campsite_type_campsite_type_id_seq to admin; + +alter table campsite_type enable row level security; + +create policy company_policy +on campsite_type +using ( + exists( + select 1 + from company_user + join user_profile using (user_id) + where company_user.company_id = campsite_type.company_id + ) +); + + +commit; diff --git a/revert/campsite_type.sql b/revert/campsite_type.sql new file mode 100644 index 0000000..76ebf52 --- /dev/null +++ b/revert/campsite_type.sql @@ -0,0 +1,7 @@ +-- Revert camper:campsite_type from pg + +begin; + +drop table if exists camper.campsite_type; + +commit; diff --git a/sqitch.plan b/sqitch.plan index 012ce07..ac5b9ea 100644 --- a/sqitch.plan +++ b/sqitch.plan @@ -36,3 +36,4 @@ country_i18n [roles schema_camper country_code language country] 2023-07-29T01:4 available_countries [schema_camper country country_i18n] 2023-07-29T01:48:40Z jordi fita mas # Add the list of available countries company [roles schema_camper extension_vat email extension_pg_libphonenumber extension_uri currency_code currency country_code country language] 2023-07-29T01:56:41Z jordi fita mas # Add relation for company company_user [roles schema_camper user company] 2023-07-29T02:08:07Z jordi fita mas # Add relation of company user +campsite_type [roles schema_camper company] 2023-07-31T11:20:29Z jordi fita mas # Add relation of campsite type diff --git a/test/campsite_type.sql b/test/campsite_type.sql new file mode 100644 index 0000000..0e3ec9e --- /dev/null +++ b/test/campsite_type.sql @@ -0,0 +1,151 @@ +-- Test campsite_type +set client_min_messages to warning; +create extension if not exists pgtap; +reset client_min_messages; + +begin; + +select plan(55); + +set search_path to camper, public; + +select has_table('campsite_type'); +select has_pk('campsite_type' ); +select table_privs_are('campsite_type', 'guest', array[]::text[]); +select table_privs_are('campsite_type', 'employee', array['SELECT']); +select table_privs_are('campsite_type', 'admin', array['SELECT', 'INSERT', 'UPDATE', 'DELETE']); +select table_privs_are('campsite_type', 'authenticator', array[]::text[]); + +select has_sequence('campsite_type_campsite_type_id_seq'); +select sequence_privs_are('campsite_type_campsite_type_id_seq', 'guest', array[]::text[]); +select sequence_privs_are('campsite_type_campsite_type_id_seq', 'employee', array[]::text[]); +select sequence_privs_are('campsite_type_campsite_type_id_seq', 'admin', array['USAGE']); +select sequence_privs_are('campsite_type_campsite_type_id_seq', 'authenticator', array[]::text[]); + +select has_column('campsite_type', 'campsite_type_id'); +select col_is_pk('campsite_type', 'campsite_type_id'); +select col_type_is('campsite_type', 'campsite_type_id', 'integer'); +select col_not_null('campsite_type', 'campsite_type_id'); +select col_has_default('campsite_type', 'campsite_type_id'); +select col_default_is('campsite_type', 'campsite_type_id', 'nextval(''campsite_type_campsite_type_id_seq''::regclass)'); + +select has_column('campsite_type', 'company_id'); +select col_is_fk('campsite_type', 'company_id'); +select fk_ok('campsite_type', 'company_id', 'company', 'company_id'); +select col_type_is('campsite_type', 'company_id', 'integer'); +select col_not_null('campsite_type', 'company_id'); +select col_hasnt_default('campsite_type', 'company_id'); + +select has_column('campsite_type', 'slug'); +select col_is_unique('campsite_type', 'slug'); +select col_type_is('campsite_type', 'slug', 'uuid'); +select col_not_null('campsite_type', 'slug'); +select col_has_default('campsite_type', 'slug'); +select col_default_is('campsite_type', 'slug', 'gen_random_uuid()'); + +select has_column('campsite_type', 'name'); +select col_type_is('campsite_type', 'name', 'text'); +select col_not_null('campsite_type', 'name'); +select col_hasnt_default('campsite_type', 'name'); + +select has_column('campsite_type', 'description'); +select col_type_is('campsite_type', 'description', 'xml'); +select col_not_null('campsite_type', 'description'); +select col_has_default('campsite_type', 'description'); +--select col_default_is('campsite_type', 'description', ''); + +select has_column('campsite_type', 'rules'); +select col_type_is('campsite_type', 'rules', 'xml'); +select col_not_null('campsite_type', 'rules'); +select col_has_default('campsite_type', 'rules'); +--select col_default_is('campsite_type', 'rules', ''); + +select has_column('campsite_type', 'booking_terms'); +select col_type_is('campsite_type', 'booking_terms', 'xml'); +select col_not_null('campsite_type', 'booking_terms'); +select col_has_default('campsite_type', 'booking_terms'); +--select col_default_is('campsite_type', 'booking_terms', ''); + +select has_column('campsite_type', 'active'); +select col_type_is('campsite_type', 'active', 'boolean'); +select col_not_null('campsite_type', 'active'); +select col_has_default('campsite_type', 'active'); +select col_default_is('campsite_type', 'active', 'true'); + + +set client_min_messages to warning; +truncate campsite_type cascade; +truncate company_user cascade; +truncate company cascade; +truncate auth."user" cascade; +reset client_min_messages; + +insert into auth."user" (user_id, email, name, password, role, cookie, cookie_expires_at) +values (1, 'demo@tandem.blog', 'Demo', 'test', 'employee', '44facbb30d8a419dfd4bfbc44a4b5539d4970148dfc84bed0e', current_timestamp + interval '1 month') + , (5, 'admin@tandem.blog', 'Demo', 'test', 'admin', '12af4c88b528c2ad4222e3740496ecbc58e76e26f087657524', current_timestamp + interval '1 month') +; + +insert into company (company_id, business_name, vatin, trade_name, phone, email, web, address, city, province, postal_code, country_code, currency_code, default_lang_tag) +values (2, 'Company 2', 'XX123', '', '555-555-555', 'a@a', '', '', '', '', '', 'ES', 'EUR', 'ca') + , (4, 'Company 4', 'XX234', '', '666-666-666', 'b@b', '', '', '', '', '', 'FR', 'USD', 'ca') +; + +insert into company_user (company_id, user_id) +values (2, 1) + , (4, 5) +; + +insert into campsite_type (company_id, name) +values (2, 'Wooden lodge') + , (4, 'Bungalow') +; + +prepare campsite_type_data as +select company_id, name +from campsite_type +order by company_id, name; + +set role employee; +select is_empty('campsite_type_data', 'Should show no data when cookie is not set yet'); +reset role; + +select set_cookie('44facbb30d8a419dfd4bfbc44a4b5539d4970148dfc84bed0e/demo@tandem.blog'); +select bag_eq( + 'campsite_type_data', + $$ values (2, 'Wooden lodge') + $$, + 'Should only list campsite types of the companies where demo@tandem.blog is user of' +); +reset role; + +select set_cookie('12af4c88b528c2ad4222e3740496ecbc58e76e26f087657524/admin@tandem.blog'); +select bag_eq( + 'campsite_type_data', + $$ values (4, 'Bungalow') + $$, + 'Should only list campsite type of the companies where admin@tandem.blog is user of' +); +reset role; + +select set_cookie('not-a-cookie'); +select throws_ok( + 'campsite_type_data', + '42501', 'permission denied for table campsite_type', + 'Should not allow select campsite types to guest users' +); +reset role; + +select throws_ok( $$ + insert into campsite_type (company_id, name) + values (2, ' ') + $$, + '23514', 'new row for relation "campsite_type" violates check constraint "name_not_empty"', + 'Should not allow campsite types with blank name' +); + + +select * +from finish(); + +rollback; + diff --git a/verify/campsite_type.sql b/verify/campsite_type.sql new file mode 100644 index 0000000..42e8195 --- /dev/null +++ b/verify/campsite_type.sql @@ -0,0 +1,19 @@ +-- Verify camper:campsite_type on pg + +begin; + +select campsite_type_id + , company_id + , slug + , name + , description + , rules + , booking_terms + , active +from camper.campsite_type +where false; + +select 1 / count(*) from pg_class where oid = 'camper.campsite_type'::regclass and relrowsecurity; +select 1 / count(*) from pg_policy where polname = 'company_policy' and polrelid = 'camper.campsite_type'::regclass; + +rollback;