tandem
/
numerus
2
0
Fork 0
Code Issues 39 Pull Requests Packages Projects 1 Releases 1 Wiki Activity
numerus/test/edit_expense.sql

104 lines
4.1 KiB
MySQL
Raw Normal View History

Add SQL function to edit expenses
2023-05-04 10:34:47 +00:00
-- Test edit_expense
set client_min_messages to warning;
create extension if not exists pgtap;
reset client_min_messages;
begin;
select plan(13);
set search_path to auth, numerus, public;
Remove the status parameter from add_expense and edit_expense, and forms Users are no longer expected to manually set the status of an expense and, instead, have to add payments to such expense to mark it as partial or paid. That means that the PL/pgSQL functions must not accept a status parameter, the edit and new forms should no longer have a field for the status, and that the expense list should no longer have the “quick edit” for their status. That’s why it no longer should have a pointer cursor, unlike invoice or quote status.
2024-08-13 00:34:21 +00:00
select has_function('numerus', 'edit_expense', array ['uuid', 'date', 'integer', 'text', 'text', 'integer[]', 'tag_name[]']);
select function_lang_is('numerus', 'edit_expense', array ['uuid', 'date', 'integer', 'text', 'text', 'integer[]', 'tag_name[]'], 'plpgsql');
select function_returns('numerus', 'edit_expense', array ['uuid', 'date', 'integer', 'text', 'text', 'integer[]', 'tag_name[]'], 'uuid');
select isnt_definer('numerus', 'edit_expense', array ['uuid', 'date', 'integer', 'text', 'text', 'integer[]', 'tag_name[]']);
select volatility_is('numerus', 'edit_expense', array ['uuid', 'date', 'integer', 'text', 'text', 'integer[]', 'tag_name[]'], 'volatile');
select function_privs_are('numerus', 'edit_expense', array ['uuid', 'date', 'integer', 'text', 'text', 'integer[]', 'tag_name[]'], 'guest', array []::text[]);
select function_privs_are('numerus', 'edit_expense', array ['uuid', 'date', 'integer', 'text', 'text', 'integer[]', 'tag_name[]'], 'invoicer', array ['EXECUTE']);
select function_privs_are('numerus', 'edit_expense', array ['uuid', 'date', 'integer', 'text', 'text', 'integer[]', 'tag_name[]'], 'admin', array ['EXECUTE']);
select function_privs_are('numerus', 'edit_expense', array ['uuid', 'date', 'integer', 'text', 'text', 'integer[]', 'tag_name[]'], 'authenticator', array []::text[]);
Add SQL function to edit expenses
2023-05-04 10:34:47 +00:00
set client_min_messages to warning;
truncate expense_tax cascade;
truncate expense cascade;
truncate contact cascade;
truncate tax cascade;
truncate tax_class cascade;
truncate payment_method cascade;
truncate company cascade;
reset client_min_messages;
set constraints "company_default_payment_method_id_fkey" deferred;
insert into company (company_id, business_name, vatin, trade_name, phone, email, web, address, city, province, postal_code, country_code, currency_code, default_payment_method_id)
values (1, 'Company 2', 'XX123', '', '555-555-555', 'a@a', '', '', '', '', '', 'ES', 'EUR', 111)
;
insert into payment_method (payment_method_id, company_id, name, instructions)
values (111, 1, 'cash', 'cash')
, (112, 1, 'bank', 'send money to my bank account')
;
set constraints "company_default_payment_method_id_fkey" immediate;
insert into tax_class (tax_class_id, company_id, name)
values (11, 1, 'tax')
;
insert into tax (tax_id, company_id, tax_class_id, name, rate)
values (3, 1, 11, 'IRPF -15 %', -0.15)
, (4, 1, 11, 'IVA 21 %', 0.21)
;
Split contact relation into tax_details, phone, web, and email We need to have contacts with just a name: we need to assign freelancer’s quote as expense linked the government, but of course we do not have a phone or email for that “contact”, much less a VATIN or other tax details. It is also interesting for other expenses-only contacts to not have to input all tax details, as we may not need to invoice then, thus are useless for us, but sometimes it might be interesting to have them, “just in case”. Of course, i did not want to make nullable any of the tax details required to generate an invoice, otherwise we could allow illegal invoices. Therefore, that data had to go in a different relation, and invoice’s foreign key update to point to that relation, not just customer, or we would again be able to create invalid invoices. We replaced the contact’s trade name with just name, because we do not need _three_ names for a contact, but we _do_ need two: the one we use to refer to them and the business name for tax purposes. The new contact_phone, contact_web, and contact_email relations could be simply a nullable field, but i did not see the point, since there are not that many instances where i need any of this data. Now company.taxDetailsForm is no longer “the same as contactForm with some extra fields”, because i have to add a check whether the user needs to invoice the contact, to check that the required values are there. I have an additional problem with the contact form when not using JavaScript: i must set the required field to all tax details fields to avoid the “(optional)” suffix, and because they _are_ required when that checkbox is enabled, but i can not set them optional when the check is unchecked. My solution for now is to ignore the form validation, and later i will add some JavaScript that adds the validation again, so it will work in all cases.
2023-06-30 19:32:48 +00:00
insert into contact (contact_id, company_id, name)
values (12, 1, 'Contact 2.1')
, (13, 1, 'Contact 2.2')
Add SQL function to edit expenses
2023-05-04 10:34:47 +00:00
;
Add expenses statuses We only want two statuses for expense: not yet paid (pending), and paid. Thus, it is a bit different from quotes and invoices, because expenses do not pass throw the “workflow” of created→sent→{pending,paid}. That’s way in this case the status field is already in the new expense form, instead of hidden, and by pending is not equivalent to created but unpaid (i.e., the same status color). With the new select field in the form, the file field no longer can span two columns or it would be alone on the next row. Closes #67.
2023-07-11 13:33:26 +00:00
insert into expense (expense_id, company_id, slug, invoice_number, invoice_date, contact_id, amount, currency_code, expense_status, tags)
values (15, 1, '7ac3ae0e-b0c1-4206-a19b-0be20835edd4', 'INV1', '2023-05-04', 12, 111, 'EUR', 'pending', '{tag1}')
, (16, 1, 'b57b980b-247b-4be4-a0b7-03a7819c53ae', 'INV2', '2023-05-05', 13, 222, 'EUR', 'paid', '{tag2}')
Add SQL function to edit expenses
2023-05-04 10:34:47 +00:00
;
insert into expense_tax (expense_id, tax_id, tax_rate)
values (15, 4, 0.21)
, (15, 3, -0.07)
, (16, 4, 0.20)
;
select lives_ok(
Remove the status parameter from add_expense and edit_expense, and forms Users are no longer expected to manually set the status of an expense and, instead, have to add payments to such expense to mark it as partial or paid. That means that the PL/pgSQL functions must not accept a status parameter, the edit and new forms should no longer have a field for the status, and that the expense list should no longer have the “quick edit” for their status. That’s why it no longer should have a pointer cursor, unlike invoice or quote status.
2024-08-13 00:34:21 +00:00
$$ select edit_expense('7ac3ae0e-b0c1-4206-a19b-0be20835edd4', '2023-05-06', 13, 'INV11', '1.12', '{4}', array['tag1']) $$,
Add SQL function to edit expenses
2023-05-04 10:34:47 +00:00
'Should be able to edit the first expense'
);
select lives_ok(
Remove the status parameter from add_expense and edit_expense, and forms Users are no longer expected to manually set the status of an expense and, instead, have to add payments to such expense to mark it as partial or paid. That means that the PL/pgSQL functions must not accept a status parameter, the edit and new forms should no longer have a field for the status, and that the expense list should no longer have the “quick edit” for their status. That’s why it no longer should have a pointer cursor, unlike invoice or quote status.
2024-08-13 00:34:21 +00:00
$$ select edit_expense('b57b980b-247b-4be4-a0b7-03a7819c53ae', '2023-05-07', 12, 'INV22', '3.33', '{4,3}', array['tag1', 'tag3']) $$,
Add SQL function to edit expenses
2023-05-04 10:34:47 +00:00
'Should be able to edit the second expense'
);
select bag_eq(
Add expenses statuses We only want two statuses for expense: not yet paid (pending), and paid. Thus, it is a bit different from quotes and invoices, because expenses do not pass throw the “workflow” of created→sent→{pending,paid}. That’s way in this case the status field is already in the new expense form, instead of hidden, and by pending is not equivalent to created but unpaid (i.e., the same status color). With the new select field in the form, the file field no longer can span two columns or it would be alone on the next row. Closes #67.
2023-07-11 13:33:26 +00:00
$$ select invoice_number, invoice_date, contact_id, amount, expense_status, tags from expense $$,
Remove the status parameter from add_expense and edit_expense, and forms Users are no longer expected to manually set the status of an expense and, instead, have to add payments to such expense to mark it as partial or paid. That means that the PL/pgSQL functions must not accept a status parameter, the edit and new forms should no longer have a field for the status, and that the expense list should no longer have the “quick edit” for their status. That’s why it no longer should have a pointer cursor, unlike invoice or quote status.
2024-08-13 00:34:21 +00:00
$$ values ('INV11', '2023-05-06'::date, 13, 112, 'pending', '{tag1}'::tag_name[])
, ('INV22', '2023-05-07'::date, 12, 333, 'paid', '{tag1,tag3}'::tag_name[])
Add SQL function to edit expenses
2023-05-04 10:34:47 +00:00
$$,
'Should have updated all expenses'
);
select bag_eq(
$$ select invoice_number, tax_id, tax_rate from expense_tax join expense using (expense_id) $$,
$$ values ('INV11', 4, 0.21)
, ('INV22', 3, -0.15)
, ('INV22', 4, 0.21)
$$,
'Should have updated all expense taxes, added new ones, and removed the ones not given to the function'
);
select *
from finish();
rollback;