2023-02-09 10:42:31 +00:00
|
|
|
-- Test invoice
|
|
|
|
set client_min_messages to warning;
|
|
|
|
create extension if not exists pgtap;
|
|
|
|
reset client_min_messages;
|
|
|
|
|
|
|
|
begin;
|
|
|
|
|
Replace tag relations with array attributes
It all started when i wanted to try to filter invoices by multiple tags
using an “AND”, instead of “OR” as it was doing until now. But
something felt off and seemed to me that i was doing thing much more
complex than needed, all to be able to list the tags as a suggestion
in the input field—which i am not doing yet.
I found this article series[0] exploring different approaches for
tagging, which includes the one i was using, and comparing their
performance. I have not actually tested it, but it seems that i have
chosen the worst option, in both query time and storage.
I attempted to try using an array attribute to each table, which is more
or less the same they did in the articles but without using a separate
relation for tags, and i found out that all the queries were way easier
to write, and needed two joins less, so it was a no-brainer.
[0]: http://www.databasesoup.com/2015/01/tag-all-things.html
2023-04-07 19:31:35 +00:00
|
|
|
select plan(83);
|
2023-02-09 10:42:31 +00:00
|
|
|
|
|
|
|
set search_path to numerus, auth, public;
|
|
|
|
|
|
|
|
select has_table('invoice');
|
|
|
|
select has_pk('invoice' );
|
|
|
|
select table_privs_are('invoice', 'guest', array []::text[]);
|
|
|
|
select table_privs_are('invoice', 'invoicer', array ['SELECT', 'INSERT', 'UPDATE', 'DELETE']);
|
|
|
|
select table_privs_are('invoice', 'admin', array ['SELECT', 'INSERT', 'UPDATE', 'DELETE']);
|
|
|
|
select table_privs_are('invoice', 'authenticator', array []::text[]);
|
|
|
|
|
|
|
|
select has_sequence('invoice_invoice_id_seq');
|
|
|
|
select sequence_privs_are('invoice_invoice_id_seq', 'guest', array[]::text[]);
|
|
|
|
select sequence_privs_are('invoice_invoice_id_seq', 'invoicer', array['USAGE']);
|
|
|
|
select sequence_privs_are('invoice_invoice_id_seq', 'admin', array['USAGE']);
|
|
|
|
select sequence_privs_are('invoice_invoice_id_seq', 'authenticator', array[]::text[]);
|
|
|
|
|
|
|
|
select has_column('invoice', 'invoice_id');
|
|
|
|
select col_is_pk('invoice', 'invoice_id');
|
|
|
|
select col_type_is('invoice', 'invoice_id', 'integer');
|
|
|
|
select col_not_null('invoice', 'invoice_id');
|
|
|
|
select col_has_default('invoice', 'invoice_id');
|
|
|
|
select col_default_is('invoice', 'invoice_id', 'nextval(''invoice_invoice_id_seq''::regclass)');
|
|
|
|
|
|
|
|
select has_column('invoice', 'company_id');
|
|
|
|
select col_is_fk('invoice', 'company_id');
|
|
|
|
select fk_ok('invoice', 'company_id', 'company', 'company_id');
|
|
|
|
select col_type_is('invoice', 'company_id', 'integer');
|
|
|
|
select col_not_null('invoice', 'company_id');
|
|
|
|
select col_hasnt_default('invoice', 'company_id');
|
|
|
|
|
|
|
|
select has_column('invoice', 'slug');
|
|
|
|
select col_is_unique('invoice', 'slug');
|
|
|
|
select col_type_is('invoice', 'slug', 'uuid');
|
|
|
|
select col_not_null('invoice', 'slug');
|
|
|
|
select col_has_default('invoice', 'slug');
|
|
|
|
select col_default_is('invoice', 'slug', 'gen_random_uuid()');
|
|
|
|
|
|
|
|
select has_column('invoice', 'invoice_number');
|
|
|
|
select col_type_is('invoice', 'invoice_number', 'text');
|
|
|
|
select col_not_null('invoice', 'invoice_number');
|
|
|
|
select col_hasnt_default('invoice', 'invoice_number');
|
|
|
|
|
|
|
|
select has_column('invoice', 'invoice_date');
|
|
|
|
select col_type_is('invoice', 'invoice_date', 'date');
|
|
|
|
select col_not_null('invoice', 'invoice_date');
|
|
|
|
select col_has_default('invoice', 'invoice_date');
|
2023-06-15 11:55:15 +00:00
|
|
|
select col_default_is('invoice', 'invoice_date', 'CURRENT_DATE');
|
2023-02-09 10:42:31 +00:00
|
|
|
|
|
|
|
select has_column('invoice', 'contact_id');
|
|
|
|
select col_is_fk('invoice', 'contact_id');
|
Split contact relation into tax_details, phone, web, and email
We need to have contacts with just a name: we need to assign
freelancer’s quote as expense linked the government, but of course we
do not have a phone or email for that “contact”, much less a VATIN or
other tax details.
It is also interesting for other expenses-only contacts to not have to
input all tax details, as we may not need to invoice then, thus are
useless for us, but sometimes it might be interesting to have them,
“just in case”.
Of course, i did not want to make nullable any of the tax details
required to generate an invoice, otherwise we could allow illegal
invoices. Therefore, that data had to go in a different relation,
and invoice’s foreign key update to point to that relation, not just
customer, or we would again be able to create invalid invoices.
We replaced the contact’s trade name with just name, because we do not
need _three_ names for a contact, but we _do_ need two: the one we use
to refer to them and the business name for tax purposes.
The new contact_phone, contact_web, and contact_email relations could be
simply a nullable field, but i did not see the point, since there are
not that many instances where i need any of this data.
Now company.taxDetailsForm is no longer “the same as contactForm with
some extra fields”, because i have to add a check whether the user needs
to invoice the contact, to check that the required values are there.
I have an additional problem with the contact form when not using
JavaScript: i must set the required field to all tax details fields to
avoid the “(optional)” suffix, and because they _are_ required when
that checkbox is enabled, but i can not set them optional when the check
is unchecked. My solution for now is to ignore the form validation,
and later i will add some JavaScript that adds the validation again,
so it will work in all cases.
2023-06-30 19:32:48 +00:00
|
|
|
select fk_ok('invoice', 'contact_id', 'contact_tax_details', 'contact_id');
|
2023-02-09 10:42:31 +00:00
|
|
|
select col_type_is('invoice', 'contact_id', 'integer');
|
|
|
|
select col_not_null('invoice', 'contact_id');
|
|
|
|
select col_hasnt_default('invoice', 'contact_id');
|
|
|
|
|
|
|
|
select has_column('invoice', 'invoice_status');
|
|
|
|
select col_is_fk('invoice', 'invoice_status');
|
|
|
|
select fk_ok('invoice', 'invoice_status', 'invoice_status', 'invoice_status');
|
|
|
|
select col_type_is('invoice', 'invoice_status', 'text');
|
|
|
|
select col_not_null('invoice', 'invoice_status');
|
|
|
|
select col_has_default('invoice', 'invoice_status');
|
|
|
|
select col_default_is('invoice', 'invoice_status', 'created');
|
|
|
|
|
|
|
|
select has_column('invoice', 'notes');
|
|
|
|
select col_type_is('invoice', 'notes', 'text');
|
|
|
|
select col_not_null('invoice', 'notes');
|
|
|
|
select col_has_default('invoice', 'notes');
|
|
|
|
select col_default_is('invoice', 'notes', '');
|
Replace tag relations with array attributes
It all started when i wanted to try to filter invoices by multiple tags
using an “AND”, instead of “OR” as it was doing until now. But
something felt off and seemed to me that i was doing thing much more
complex than needed, all to be able to list the tags as a suggestion
in the input field—which i am not doing yet.
I found this article series[0] exploring different approaches for
tagging, which includes the one i was using, and comparing their
performance. I have not actually tested it, but it seems that i have
chosen the worst option, in both query time and storage.
I attempted to try using an array attribute to each table, which is more
or less the same they did in the articles but without using a separate
relation for tags, and i found out that all the queries were way easier
to write, and needed two joins less, so it was a no-brainer.
[0]: http://www.databasesoup.com/2015/01/tag-all-things.html
2023-04-07 19:31:35 +00:00
|
|
|
|
|
|
|
select has_column('invoice', 'tags');
|
|
|
|
select col_type_is('invoice', 'tags', 'tag_name[]');
|
|
|
|
select col_not_null('invoice', 'tags');
|
|
|
|
select col_has_default('invoice', 'tags');
|
|
|
|
select col_default_is('invoice', 'tags', '{}');
|
2023-02-09 10:42:31 +00:00
|
|
|
|
2023-03-05 17:50:57 +00:00
|
|
|
select has_column('invoice', 'payment_method_id');
|
|
|
|
select col_is_fk('invoice', 'payment_method_id');
|
|
|
|
select fk_ok('invoice', 'payment_method_id', 'payment_method', 'payment_method_id');
|
|
|
|
select col_type_is('invoice', 'payment_method_id', 'integer');
|
|
|
|
select col_not_null('invoice', 'payment_method_id');
|
|
|
|
select col_hasnt_default('invoice', 'payment_method_id');
|
|
|
|
|
2023-02-09 10:42:31 +00:00
|
|
|
select has_column('invoice', 'currency_code');
|
|
|
|
select col_is_fk('invoice', 'currency_code');
|
|
|
|
select fk_ok('invoice', 'currency_code', 'currency', 'currency_code');
|
|
|
|
select col_type_is('invoice', 'currency_code', 'text');
|
|
|
|
select col_not_null('invoice', 'currency_code');
|
|
|
|
select col_hasnt_default('invoice', 'currency_code');
|
|
|
|
|
|
|
|
select has_column('invoice', 'created_at');
|
|
|
|
select col_type_is('invoice', 'created_at', 'timestamp with time zone');
|
|
|
|
select col_not_null('invoice', 'created_at');
|
|
|
|
select col_has_default('invoice', 'created_at');
|
2023-06-15 11:55:15 +00:00
|
|
|
select col_default_is('invoice', 'created_at', 'CURRENT_TIMESTAMP');
|
2023-02-09 10:42:31 +00:00
|
|
|
|
|
|
|
|
|
|
|
set client_min_messages to warning;
|
2023-02-10 18:00:22 +00:00
|
|
|
truncate invoice cascade;
|
Split contact relation into tax_details, phone, web, and email
We need to have contacts with just a name: we need to assign
freelancer’s quote as expense linked the government, but of course we
do not have a phone or email for that “contact”, much less a VATIN or
other tax details.
It is also interesting for other expenses-only contacts to not have to
input all tax details, as we may not need to invoice then, thus are
useless for us, but sometimes it might be interesting to have them,
“just in case”.
Of course, i did not want to make nullable any of the tax details
required to generate an invoice, otherwise we could allow illegal
invoices. Therefore, that data had to go in a different relation,
and invoice’s foreign key update to point to that relation, not just
customer, or we would again be able to create invalid invoices.
We replaced the contact’s trade name with just name, because we do not
need _three_ names for a contact, but we _do_ need two: the one we use
to refer to them and the business name for tax purposes.
The new contact_phone, contact_web, and contact_email relations could be
simply a nullable field, but i did not see the point, since there are
not that many instances where i need any of this data.
Now company.taxDetailsForm is no longer “the same as contactForm with
some extra fields”, because i have to add a check whether the user needs
to invoice the contact, to check that the required values are there.
I have an additional problem with the contact form when not using
JavaScript: i must set the required field to all tax details fields to
avoid the “(optional)” suffix, and because they _are_ required when
that checkbox is enabled, but i can not set them optional when the check
is unchecked. My solution for now is to ignore the form validation,
and later i will add some JavaScript that adds the validation again,
so it will work in all cases.
2023-06-30 19:32:48 +00:00
|
|
|
truncate contact_tax_details cascade;
|
2023-02-09 10:42:31 +00:00
|
|
|
truncate contact cascade;
|
|
|
|
truncate company_user cascade;
|
|
|
|
truncate company cascade;
|
2023-03-04 21:15:52 +00:00
|
|
|
truncate payment_method cascade;
|
2023-02-09 10:42:31 +00:00
|
|
|
truncate auth."user" cascade;
|
|
|
|
reset client_min_messages;
|
|
|
|
|
|
|
|
insert into auth."user" (user_id, email, name, password, role, cookie, cookie_expires_at)
|
|
|
|
values (1, 'demo@tandem.blog', 'Demo', 'test', 'invoicer', '44facbb30d8a419dfd4bfbc44a4b5539d4970148dfc84bed0e', current_timestamp + interval '1 month')
|
|
|
|
, (5, 'admin@tandem.blog', 'Demo', 'test', 'admin', '12af4c88b528c2ad4222e3740496ecbc58e76e26f087657524', current_timestamp + interval '1 month')
|
|
|
|
;
|
|
|
|
|
2023-03-04 21:15:52 +00:00
|
|
|
set constraints "company_default_payment_method_id_fkey" deferred;
|
|
|
|
|
|
|
|
insert into company (company_id, business_name, vatin, trade_name, phone, email, web, address, city, province, postal_code, country_code, currency_code, default_payment_method_id)
|
|
|
|
values (2, 'Company 2', 'XX123', '', '555-555-555', 'a@a', '', '', '', '', '', 'ES', 'EUR', 222)
|
|
|
|
, (4, 'Company 4', 'XX234', '', '666-666-666', 'b@b', '', '', '', '', '', 'FR', 'USD', 444)
|
|
|
|
;
|
|
|
|
|
|
|
|
insert into payment_method (payment_method_id, company_id, name, instructions)
|
|
|
|
values (444, 4, 'cash', 'cash')
|
|
|
|
, (222, 2, 'cash', 'cash')
|
2023-02-09 10:42:31 +00:00
|
|
|
;
|
|
|
|
|
2023-03-04 21:15:52 +00:00
|
|
|
set constraints "company_default_payment_method_id_fkey" immediate;
|
|
|
|
|
2023-02-09 10:42:31 +00:00
|
|
|
insert into company_user (company_id, user_id)
|
|
|
|
values (2, 1)
|
|
|
|
, (4, 5)
|
|
|
|
;
|
|
|
|
|
Split contact relation into tax_details, phone, web, and email
We need to have contacts with just a name: we need to assign
freelancer’s quote as expense linked the government, but of course we
do not have a phone or email for that “contact”, much less a VATIN or
other tax details.
It is also interesting for other expenses-only contacts to not have to
input all tax details, as we may not need to invoice then, thus are
useless for us, but sometimes it might be interesting to have them,
“just in case”.
Of course, i did not want to make nullable any of the tax details
required to generate an invoice, otherwise we could allow illegal
invoices. Therefore, that data had to go in a different relation,
and invoice’s foreign key update to point to that relation, not just
customer, or we would again be able to create invalid invoices.
We replaced the contact’s trade name with just name, because we do not
need _three_ names for a contact, but we _do_ need two: the one we use
to refer to them and the business name for tax purposes.
The new contact_phone, contact_web, and contact_email relations could be
simply a nullable field, but i did not see the point, since there are
not that many instances where i need any of this data.
Now company.taxDetailsForm is no longer “the same as contactForm with
some extra fields”, because i have to add a check whether the user needs
to invoice the contact, to check that the required values are there.
I have an additional problem with the contact form when not using
JavaScript: i must set the required field to all tax details fields to
avoid the “(optional)” suffix, and because they _are_ required when
that checkbox is enabled, but i can not set them optional when the check
is unchecked. My solution for now is to ignore the form validation,
and later i will add some JavaScript that adds the validation again,
so it will work in all cases.
2023-06-30 19:32:48 +00:00
|
|
|
insert into contact (contact_id, company_id, name)
|
|
|
|
values (6, 2, 'Contact 1')
|
|
|
|
, (8, 4, 'Contact 2')
|
|
|
|
;
|
|
|
|
|
|
|
|
insert into contact_tax_details (contact_id, business_name, vatin, address, city, province, postal_code, country_code)
|
|
|
|
values (6, 'Contact 1', 'XX555', '', '', '', '', 'ES')
|
|
|
|
, (8, 'Contact 2', 'XX666', '', '', '', '', 'ES')
|
2023-02-09 10:42:31 +00:00
|
|
|
;
|
|
|
|
|
2023-03-05 17:50:57 +00:00
|
|
|
insert into invoice (company_id, invoice_number, contact_id, currency_code, payment_method_id)
|
|
|
|
values (2, 'INV020001', 6, 'EUR', 222)
|
|
|
|
, (4, 'INV040001', 8, 'EUR', 444)
|
2023-02-09 10:42:31 +00:00
|
|
|
;
|
|
|
|
|
|
|
|
|
|
|
|
prepare invoice_data as
|
|
|
|
select company_id, invoice_number
|
|
|
|
from invoice
|
|
|
|
order by company_id, invoice_number;
|
|
|
|
|
|
|
|
set role invoicer;
|
|
|
|
select is_empty('invoice_data', 'Should show no data when cookie is not set yet');
|
|
|
|
reset role;
|
|
|
|
|
|
|
|
select set_cookie('44facbb30d8a419dfd4bfbc44a4b5539d4970148dfc84bed0e/demo@tandem.blog');
|
|
|
|
select bag_eq(
|
|
|
|
'invoice_data',
|
|
|
|
$$ values (2, 'INV020001')
|
|
|
|
$$,
|
|
|
|
'Should only list invoices of the companies where demo@tandem.blog is user of'
|
|
|
|
);
|
|
|
|
reset role;
|
|
|
|
|
|
|
|
select set_cookie('12af4c88b528c2ad4222e3740496ecbc58e76e26f087657524/admin@tandem.blog');
|
|
|
|
select bag_eq(
|
|
|
|
'invoice_data',
|
|
|
|
$$ values (4, 'INV040001')
|
|
|
|
$$,
|
|
|
|
'Should only list invoices of the companies where admin@tandem.blog is user of'
|
|
|
|
);
|
|
|
|
reset role;
|
|
|
|
|
|
|
|
select set_cookie('not-a-cookie');
|
|
|
|
select throws_ok(
|
|
|
|
'invoice_data',
|
|
|
|
'42501', 'permission denied for table invoice',
|
|
|
|
'Should not allow select to guest users'
|
|
|
|
);
|
|
|
|
reset role;
|
|
|
|
|
|
|
|
|
2023-02-17 11:39:32 +00:00
|
|
|
select throws_ok( $$
|
2023-03-05 17:50:57 +00:00
|
|
|
insert into invoice (company_id, invoice_number, contact_id, currency_code, payment_method_id)
|
|
|
|
values (2, ' ', 6, 'EUR', 222)
|
2023-02-17 11:39:32 +00:00
|
|
|
$$,
|
|
|
|
'23514', 'new row for relation "invoice" violates check constraint "invoice_number_not_empty"',
|
|
|
|
'Should not allow invoice with blank number'
|
|
|
|
);
|
|
|
|
|
|
|
|
|
2023-02-09 10:42:31 +00:00
|
|
|
select *
|
|
|
|
from finish();
|
|
|
|
|
|
|
|
rollback;
|
|
|
|
|