numerus/revert/parse_price@v1.sql

-- Revert numerus:parse_price from pg

begin;

drop function if exists numerus.parse_price(text, integer);

commit;
Fix compute_new_expense_amount to set 0.00 to taxes when subtotal is '' The problem is that parse_price('', 2) returned NULL instead of throwing and exception: it seems that accessing var[1] of a text[] variable set to the empty array, {}, returns NULL, and NULL::integer is, of course, still NULL. Apparently, this is the only case, until now, that i had an empty subtotal, and i did not know what to do: should i keep the function as is and just handle its NULL return, change it to return 0 in that case, or raise an exception? The argument for the first two options, to leave it as is or to return zero, was that it was convenient for me to allow empty strings as input values, because that’s what i get from an empty <input>; returning zero would avoid an extra coalesce everywhere the function was used. The argument in favor to the last option, an exception, was that the empty string does not represent an integer, nor a “unknown” (NULL) integer, therefore the function should do the same when i pass in any other string that does not represent an integer, just as “a.b”. At the end i went for option three, because it is the one that breaks fewer expectatives: casting an empty string to integer, or passing an empty string as the first value to to_number() throw and exception in PostgreSQL; my function should do the same. Heck, that what i expected it to do because of the casting inside the function. To still allow empty strings as parameter to compute_new_expense_amount, the only case so far, i only had to check for that empty string and convert it to the string representation of zero, so that parse_price returns the value i want for that function. This, of course, breaks the same expectatives as returning NULL for to_price, but i think it is OK in this case because to_price is more general—used in many more cases—than compute_new_expense_amount, which is only intended for that HTML form. Closes #77. 2023-08-25 12:19:27 +00:00			`-- Revert numerus:parse_price from pg`

			`begin;`

			`drop function if exists numerus.parse_price(text, integer);`

			`commit;`