tandem
/
numerus
2
0
Fork 0
Code Issues 39 Pull Requests Packages Projects 1 Releases 1 Wiki Activity
numerus/test/expense_attachment.sql

145 lines
5.0 KiB
MySQL
Raw Permalink Normal View History

Add the relation to store the expense’s attachment files It is a separate table because we allow expenses to not have such an attachment, although we allow only an attachment per expense, and i do not want to have a bunch of nullable columns for that. I decided to keep the files in the database, contrary to “conventional wisdom” of storing files in the filesystem, because these attachments are invoices and such documets that are an integral part of the expense relation. In other words, losing these files would render the expense (almost) useless. Thus, the ACID guarantees of the database are the most appropriate place for them.
2023-05-13 19:23:24 +00:00
-- Test expense_attachment
set client_min_messages to warning;
create extension if not exists pgtap;
reset client_min_messages;
begin;
select plan(29);
set search_path to numerus, auth, public;
select has_table('expense_attachment');
select has_pk('expense_attachment' );
select table_privs_are('expense_attachment', 'guest', array []::text[]);
select table_privs_are('expense_attachment', 'invoicer', array ['SELECT', 'INSERT', 'UPDATE', 'DELETE']);
select table_privs_are('expense_attachment', 'admin', array ['SELECT', 'INSERT', 'UPDATE', 'DELETE']);
select table_privs_are('expense_attachment', 'authenticator', array []::text[]);
select has_column('expense_attachment', 'expense_id');
select col_is_pk('expense_attachment', 'expense_id');
select col_is_fk('expense_attachment', 'expense_id');
select fk_ok('expense_attachment', 'expense_id', 'expense', 'expense_id');
select col_type_is('expense_attachment', 'expense_id', 'integer');
select col_not_null('expense_attachment', 'expense_id');
select col_hasnt_default('expense_attachment', 'expense_id');
select has_column('expense_attachment', 'original_filename');
select col_type_is('expense_attachment', 'original_filename', 'text');
select col_not_null('expense_attachment', 'original_filename');
select col_hasnt_default('expense_attachment', 'original_filename');
select has_column('expense_attachment', 'mime_type');
select col_type_is('expense_attachment', 'mime_type', 'text');
select col_not_null('expense_attachment', 'mime_type');
select col_hasnt_default('expense_attachment', 'mime_type');
select has_column('expense_attachment', 'content');
select col_type_is('expense_attachment', 'content', 'bytea');
select col_not_null('expense_attachment', 'content');
select col_hasnt_default('expense_attachment', 'content');
set client_min_messages to warning;
truncate expense_attachment cascade;
truncate expense cascade;
truncate tax cascade;
truncate tax_class cascade;
truncate contact cascade;
truncate company_user cascade;
truncate payment_method cascade;
truncate company cascade;
truncate auth."user" cascade;
reset client_min_messages;
insert into auth."user" (user_id, email, name, password, role, cookie, cookie_expires_at)
values (1, 'demo@tandem.blog', 'Demo', 'test', 'invoicer', '44facbb30d8a419dfd4bfbc44a4b5539d4970148dfc84bed0e', current_timestamp + interval '1 month')
, (5, 'admin@tandem.blog', 'Demo', 'test', 'admin', '12af4c88b528c2ad4222e3740496ecbc58e76e26f087657524', current_timestamp + interval '1 month')
;
set constraints "company_default_payment_method_id_fkey" deferred;
insert into company (company_id, business_name, vatin, trade_name, phone, email, web, address, city, province, postal_code, country_code, currency_code, default_payment_method_id)
values (2, 'Company 2', 'XX123', '', '555-555-555', 'a@a', '', '', '', '', '', 'ES', 'EUR', 222)
, (4, 'Company 4', 'XX234', '', '666-666-666', 'b@b', '', '', '', '', '', 'FR', 'USD', 444)
;
insert into payment_method (payment_method_id, company_id, name, instructions)
values (444, 4, 'cash', 'cash')
, (222, 2, 'cash', 'cash')
;
set constraints "company_default_payment_method_id_fkey" immediate;
insert into company_user (company_id, user_id)
values (2, 1)
, (4, 5)
;
insert into tax_class (tax_class_id, company_id, name)
values (22, 2, 'vat')
, (44, 4, 'vat')
;
insert into tax (tax_id, company_id, tax_class_id, name, rate)
values (3, 2, 22, 'IVA 21 %', 0.21)
, (6, 4, 44, 'IVA 10 %', 0.10)
;
Split contact relation into tax_details, phone, web, and email We need to have contacts with just a name: we need to assign freelancer’s quote as expense linked the government, but of course we do not have a phone or email for that “contact”, much less a VATIN or other tax details. It is also interesting for other expenses-only contacts to not have to input all tax details, as we may not need to invoice then, thus are useless for us, but sometimes it might be interesting to have them, “just in case”. Of course, i did not want to make nullable any of the tax details required to generate an invoice, otherwise we could allow illegal invoices. Therefore, that data had to go in a different relation, and invoice’s foreign key update to point to that relation, not just customer, or we would again be able to create invalid invoices. We replaced the contact’s trade name with just name, because we do not need _three_ names for a contact, but we _do_ need two: the one we use to refer to them and the business name for tax purposes. The new contact_phone, contact_web, and contact_email relations could be simply a nullable field, but i did not see the point, since there are not that many instances where i need any of this data. Now company.taxDetailsForm is no longer “the same as contactForm with some extra fields”, because i have to add a check whether the user needs to invoice the contact, to check that the required values are there. I have an additional problem with the contact form when not using JavaScript: i must set the required field to all tax details fields to avoid the “(optional)” suffix, and because they _are_ required when that checkbox is enabled, but i can not set them optional when the check is unchecked. My solution for now is to ignore the form validation, and later i will add some JavaScript that adds the validation again, so it will work in all cases.
2023-06-30 19:32:48 +00:00
insert into contact (contact_id, company_id, name)
values ( 9, 2, 'Customer 1')
, (10, 4, 'Customer 2')
Add the relation to store the expense’s attachment files It is a separate table because we allow expenses to not have such an attachment, although we allow only an attachment per expense, and i do not want to have a bunch of nullable columns for that. I decided to keep the files in the database, contrary to “conventional wisdom” of storing files in the filesystem, because these attachments are invoices and such documets that are an integral part of the expense relation. In other words, losing these files would render the expense (almost) useless. Thus, the ACID guarantees of the database are the most appropriate place for them.
2023-05-13 19:23:24 +00:00
;
insert into expense (expense_id, company_id, invoice_number, contact_id, invoice_date, amount, currency_code)
values (13, 2, 'INV001', 9, '2011-01-11', 111, 'EUR')
, (14, 4, 'INV002', 10, '2022-02-22', 222, 'EUR')
;
insert into expense_attachment (expense_id, original_filename, mime_type, content)
values (13, 'expense.txt', 'text/plain', convert_to('IOU 42', 'UTF8'))
, (14, 'expense.html', 'text/html', convert_to('<html>IOU <em>42</em></html>', 'UTF8'))
;
prepare expense_attachment_data as
select expense_id, original_filename
from expense_attachment
order by expense_id, original_filename;
set role invoicer;
select is_empty('expense_attachment_data', 'Should show no data when cookie is not set yet');
reset role;
select set_cookie('44facbb30d8a419dfd4bfbc44a4b5539d4970148dfc84bed0e/demo@tandem.blog');
select bag_eq(
'expense_attachment_data',
$$ values (13, 'expense.txt')
$$,
'Should only list tax of products of the companies where demo@tandem.blog is user of'
);
reset role;
select set_cookie('12af4c88b528c2ad4222e3740496ecbc58e76e26f087657524/admin@tandem.blog');
select bag_eq(
'expense_attachment_data',
$$ values (14, 'expense.html')
$$,
'Should only list tax of products of the companies where admin@tandem.blog is user of'
);
reset role;
select set_cookie('not-a-cookie');
select throws_ok(
'expense_attachment_data',
'42501', 'permission denied for table expense_attachment',
'Should not allow select to guest users'
);
reset role;
select *
from finish();
rollback;