From 4162da3a06c59f3cc4640e59fa55b28a01636181 Mon Sep 17 00:00:00 2001
From: jordi fita mas <jordi@tandem.blog>
Date: Sat, 29 Apr 2023 15:59:26 +0200
Subject: [PATCH] Force Content-Type to text/html when rendering a template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

By chance, i found out that sometimes Go returned a Content-Type header
of text/plain for some responses to HTMx request.  Go’s documentation
for http.ResponseWriter.Write sheds some light to this issue:

> If the Header does not contain a Content-Type line, Write adds a
> Content-Type set to the result of passing the initial 512 bytes of
> written data to DetectContentType.

http.DetectContentType has “sniff signatures” for the most common HTML
elements, such as `<BODY`, `<P`, or even `<!--`, but when the template
only has elements not in that list, the text “text sniff signature”
kicks in because the content does not contain binary data bytes, as
specified in [0], §7.1, step 9.

I can not change mustRenderTemplate’s wr parameter, and its callers’,
to be of type http.ResponseWriter because mustWriteInvoicePdf writes
the template to a pipe object, which is not of this type.  Thus, i have
to resort to type assertion inside the method.

[0]: https://mimesniff.spec.whatwg.org/#identifying-a-resource-with-an-unknown-mime-type
---
 pkg/template.go | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pkg/template.go b/pkg/template.go
index 63158e5..1ed9afc 100644
--- a/pkg/template.go
+++ b/pkg/template.go
@@ -84,6 +84,9 @@ func mustRenderTemplate(wr io.Writer, r *http.Request, layout string, filename s
 	if _, err := t.ParseFiles(templateFile(filename), templateFile(layout), templateFile("form.gohtml")); err != nil {
 		panic(err)
 	}
+	if w, ok := wr.(http.ResponseWriter); ok {
+		w.Header().Set("Content-Type", "text/html; charset=utf-8")
+	}
 	if err := t.ExecuteTemplate(wr, layout, data); err != nil {
 		panic(err)
 	}