From cbe868b6d66a7247a1581aa70be0937fa9002934 Mon Sep 17 00:00:00 2001 From: jordi fita mas Date: Fri, 26 May 2023 13:30:45 +0200 Subject: [PATCH] =?UTF-8?q?Remove=20=E2=80=9Cshadow=E2=80=9D=20variables?= =?UTF-8?q?=20inside=20invoices.ServeInvoice?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- pkg/invoices.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pkg/invoices.go b/pkg/invoices.go index 783f211..2944f8c 100644 --- a/pkg/invoices.go +++ b/pkg/invoices.go @@ -234,14 +234,12 @@ func ServeInvoice(w http.ResponseWriter, r *http.Request, params httprouter.Para w.WriteHeader(http.StatusOK) mustRenderNewInvoiceForm(w, r, form) case "product-form": - company := mustGetCompany(r) query := r.URL.Query() index, _ := strconv.Atoi(query.Get("index")) - conn := getConn(r) form := newInvoiceProductForm(index, company, getLocale(r), mustGetTaxOptions(r.Context(), conn, company)) - slug := query.Get("slug") - if len(slug) > 0 { - if !form.MustFillFromDatabase(r.Context(), conn, slug) { + productSlug := query.Get("slug") + if len(productSlug) > 0 { + if !form.MustFillFromDatabase(r.Context(), conn, productSlug) { http.NotFound(w, r) return }