jordi fita mas
1c0f126c58
We need to have contacts with just a name: we need to assign freelancer’s quote as expense linked the government, but of course we do not have a phone or email for that “contact”, much less a VATIN or other tax details. It is also interesting for other expenses-only contacts to not have to input all tax details, as we may not need to invoice then, thus are useless for us, but sometimes it might be interesting to have them, “just in case”. Of course, i did not want to make nullable any of the tax details required to generate an invoice, otherwise we could allow illegal invoices. Therefore, that data had to go in a different relation, and invoice’s foreign key update to point to that relation, not just customer, or we would again be able to create invalid invoices. We replaced the contact’s trade name with just name, because we do not need _three_ names for a contact, but we _do_ need two: the one we use to refer to them and the business name for tax purposes. The new contact_phone, contact_web, and contact_email relations could be simply a nullable field, but i did not see the point, since there are not that many instances where i need any of this data. Now company.taxDetailsForm is no longer “the same as contactForm with some extra fields”, because i have to add a check whether the user needs to invoice the contact, to check that the required values are there. I have an additional problem with the contact form when not using JavaScript: i must set the required field to all tax details fields to avoid the “(optional)” suffix, and because they _are_ required when that checkbox is enabled, but i can not set them optional when the check is unchecked. My solution for now is to ignore the form validation, and later i will add some JavaScript that adds the validation again, so it will work in all cases.
110 lines
4.8 KiB
PL/PgSQL
110 lines
4.8 KiB
PL/PgSQL
-- Test add_contact
|
||
set client_min_messages to warning;
|
||
create extension if not exists pgtap;
|
||
reset client_min_messages;
|
||
|
||
begin;
|
||
|
||
select plan(18);
|
||
|
||
set search_path to auth, numerus, public;
|
||
|
||
select has_function('numerus', 'add_contact', array ['integer', 'text', 'text', 'email', 'uri', 'tax_details', 'tag_name[]']);
|
||
select function_lang_is('numerus', 'add_contact', array ['integer', 'text', 'text', 'email', 'uri', 'tax_details', 'tag_name[]'], 'plpgsql');
|
||
select function_returns('numerus', 'add_contact', array ['integer', 'text', 'text', 'email', 'uri', 'tax_details', 'tag_name[]'], 'uuid');
|
||
select isnt_definer('numerus', 'add_contact', array ['integer', 'text', 'text', 'email', 'uri', 'tax_details', 'tag_name[]']);
|
||
select volatility_is('numerus', 'add_contact', array ['integer', 'text', 'text', 'email', 'uri', 'tax_details', 'tag_name[]'], 'volatile');
|
||
select function_privs_are('numerus', 'add_contact', array ['integer', 'text', 'text', 'email', 'uri', 'tax_details', 'tag_name[]'], 'guest', array []::text[]);
|
||
select function_privs_are('numerus', 'add_contact', array ['integer', 'text', 'text', 'email', 'uri', 'tax_details', 'tag_name[]'], 'invoicer', array ['EXECUTE']);
|
||
select function_privs_are('numerus', 'add_contact', array ['integer', 'text', 'text', 'email', 'uri', 'tax_details', 'tag_name[]'], 'admin', array ['EXECUTE']);
|
||
select function_privs_are('numerus', 'add_contact', array ['integer', 'text', 'text', 'email', 'uri', 'tax_details', 'tag_name[]'], 'authenticator', array []::text[]);
|
||
|
||
|
||
set client_min_messages to warning;
|
||
truncate contact cascade;
|
||
truncate payment_method cascade;
|
||
truncate company cascade;
|
||
reset client_min_messages;
|
||
|
||
set constraints "company_default_payment_method_id_fkey" deferred;
|
||
|
||
insert into company (company_id, business_name, vatin, trade_name, phone, email, web, address, city, province, postal_code, country_code, currency_code, default_payment_method_id)
|
||
values (1, 'Company 2', 'XX123', '', '555-555-555', 'a@a', '', '', '', '', '', 'ES', 'EUR', 111)
|
||
, (2, 'Company 4', 'XX234', '', '666-666-666', 'b@b', '', '', '', '', '', 'FR', 'USD', 222)
|
||
;
|
||
|
||
insert into payment_method (payment_method_id, company_id, name, instructions)
|
||
values (111, 1, 'cash', 'cash')
|
||
, (222, 2, 'cash', 'cash')
|
||
;
|
||
|
||
set constraints "company_default_payment_method_id_fkey" immediate;
|
||
|
||
select lives_ok(
|
||
$$ select add_contact(1, 'Contact 2.1', '777-777-777', null, 'https://c', null, '{tag1,tag2}') $$,
|
||
'Should be able to insert a contact for the first company with two tags, no email, and no tax details'
|
||
);
|
||
|
||
select lives_ok(
|
||
$$ select add_contact(1, 'Contact 2.2', null, 'd@d', null, '(Contact 2.2 Ltd,41414141L,"Fake St., 123",City 2.2,Province 2.2,17487,ES)', '{}') $$,
|
||
'Should be able to insert a second contact for the first company with no tag, no phone, and not website'
|
||
);
|
||
|
||
select lives_ok(
|
||
$$ select add_contact(2, 'Contact 4.1', '999-999-999', 'e@e', 'http://e', '(Contact 4.1 Ltd,42424242Y,"Another Fake St., 123",City 4.1,Province 4.1,17488,ES)', '{tag2}') $$,
|
||
'Should be able to insert a contact for the second company with a tag and everything else'
|
||
);
|
||
|
||
select lives_ok(
|
||
$$ select add_contact(1, 'Contact 2.3', null, null, null, null, '{tag2}') $$,
|
||
'Should be able to insert another contact with a repeated tag'
|
||
);
|
||
|
||
select bag_eq(
|
||
$$ select company_id, name, tags, created_at from contact $$,
|
||
$$ values (1, 'Contact 2.1', '{tag1,tag2}'::tag_name[], CURRENT_TIMESTAMP)
|
||
, (1, 'Contact 2.2', '{}'::tag_name[], CURRENT_TIMESTAMP)
|
||
, (2, 'Contact 4.1', '{tag2}'::tag_name[], CURRENT_TIMESTAMP)
|
||
, (1, 'Contact 2.3', '{tag2}'::tag_name[], CURRENT_TIMESTAMP)
|
||
$$,
|
||
'Should have created all contacts'
|
||
);
|
||
|
||
select bag_eq(
|
||
$$ select name, business_name, vatin::text, address, city, province, postal_code, country_code::text from contact join contact_tax_details using (contact_id) $$,
|
||
$$ values ('Contact 2.2', 'Contact 2.2 Ltd', 'ES41414141L', 'Fake St., 123', 'City 2.2', 'Province 2.2', '17487', 'ES')
|
||
, ('Contact 4.1', 'Contact 4.1 Ltd', 'ES42424242Y', 'Another Fake St., 123', 'City 4.1', 'Province 4.1', '17488', 'ES')
|
||
$$,
|
||
'Should have created all contacts’ tax details'
|
||
);
|
||
|
||
select bag_eq(
|
||
$$ select name, phone::text from contact join contact_phone using (contact_id) $$,
|
||
$$ values ('Contact 2.1', '+34 777 77 77 77')
|
||
, ('Contact 4.1', '+34 999 99 99 99')
|
||
$$,
|
||
'Should have created all contacts’ phone'
|
||
);
|
||
|
||
select bag_eq(
|
||
$$ select name, email::text from contact join contact_email using (contact_id) $$,
|
||
$$ values ('Contact 2.2', 'd@d')
|
||
, ('Contact 4.1', 'e@e')
|
||
$$,
|
||
'Should have created all contacts’ email'
|
||
);
|
||
|
||
select bag_eq(
|
||
$$ select name, uri::text from contact join contact_web using (contact_id) $$,
|
||
$$ values ('Contact 2.1', 'https://c')
|
||
, ('Contact 4.1', 'http://e')
|
||
$$,
|
||
'Should have created all contacts’ web'
|
||
);
|
||
|
||
|
||
select *
|
||
from finish();
|
||
|
||
rollback;
|