tandem
/
vat
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a problem with CIF checksum due to using char instead of int

This commit is contained in:
jordi fita mas 2023-06-20 19:41:54 +02:00
parent c229754d6a
commit 9635b2f3a3
4 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
debian/changelog vendored
View File

@ -1,3 +1,9 @@
vat (0.0-2) bookworm; urgency=medium
* Fix CIF computation.
-- jordi fita mas <jordi@tandem.blog> Sat, 21 Jan 2023 19:41:05 +0002
vat (0.0-1) bullseye; urgency=medium vat (0.0-1) bullseye; urgency=medium
* Initial release. * Initial release.

2
es.c
View File

@ -50,7 +50,7 @@ valid_cif(const char *cif) {
if (n % 2 == 0) { if (n % 2 == 0) {
evens += cif[n] - 48; evens += cif[n] - 48;
} else { } else {
int d = cif[n] * 2; int d = (cif[n] - 48) * 2;
int a = d / 10; int a = d / 10;
int b = d % 10; int b = d % 10;
odds += a + b; odds += a + b;

9
expected/vat.out
View File

@ -7,11 +7,12 @@ SELECT 'ES40404040D'::VATIN,
'ES40404040-D'::VATIN, 'ES40404040-D'::VATIN,
' esx0523821l '::VATIN, ' esx0523821l '::VATIN,
'ESM0243487d'::VATIN, 'ESM0243487d'::VATIN,
' ESb17616756 '::VATIN ' ESb17616756 '::VATIN,
'ESb17385717'::VATIN
; ;
vatin | vatin | vatin | vatin | vatin vatin | vatin | vatin | vatin | vatin | vatin
-------------+-------------+-------------+-------------+------------- -------------+-------------+-------------+-------------+-------------+-------------
ES40404040D | ES40404040D | ESX0523821L | ESM0243487D | ESB17616756 ES40404040D | ES40404040D | ESX0523821L | ESM0243487D | ESB17616756 | ESB17385717
(1 row) (1 row)
-- Test invalid checksums -- Test invalid checksums

3
sql/vat.sql
View File

@ -9,7 +9,8 @@ SELECT 'ES40404040D'::VATIN,
'ES40404040-D'::VATIN, 'ES40404040-D'::VATIN,
' esx0523821l '::VATIN, ' esx0523821l '::VATIN,
'ESM0243487d'::VATIN, 'ESM0243487d'::VATIN,
' ESb17616756 '::VATIN ' ESb17616756 '::VATIN,
'ESb17385717'::VATIN
; ;
-- Test invalid checksums -- Test invalid checksums